Update to latest reactor-netty stack #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markfisher
reviewed
Dec 16, 2016
| Thread.sleep(100L); | ||
| } | ||
| catch (InterruptedException e) { | ||
| Thread.currentThread().interrupt(); |
Contributor
Author
There was a problem hiding this comment.
Probably throw an exception?
markfisher
reviewed
Dec 16, 2016
| private final int port; | ||
|
|
||
| private volatile HttpServer server; | ||
| private volatile NettyContext server; |
Contributor
There was a problem hiding this comment.
should we change the variable name here as well?
Contributor
Author
There was a problem hiding this comment.
I don't know how stable it is. I don't mind either way. Just wanted something that works.
I figure we'll migrate to spring boot stack eventually anyway.
Contributor
|
LGTM; merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if there is a better way to wait for the server,
but this seems to work.