Skip to content

Restore common images by key (pipeline bug) #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 1, 2024
Merged

Restore common images by key (pipeline bug) #1749

merged 5 commits into from
Oct 1, 2024

Conversation

@wind57
Copy link
Contributor

@wind57 wind57 commented Sep 30, 2024

No description provided.

@wind57 wind57 changed the title Restore common images by key Restore common images by key (pipeline bug) Sep 30, 2024
@wind57
Copy link
Contributor Author

wind57 commented Sep 30, 2024

without this fix, we would never actually get a cache hit, and would always download images. With it:

Received 800489990 of 800489990 (100.0%), 76.3 MBs/sec
Cache restored successfully
Cache restored from key: docker-images-github-cache-ec48dd5c4cf2f404357bd6116429d6591efe70ff00e240da988925187536b1c

@wind57 wind57 marked this pull request as ready for review October 1, 2024 04:32
@wind57
Copy link
Contributor Author

wind57 commented Oct 1, 2024

@ryanjbaxter ready to be looked at. thank you

@ryanjbaxter ryanjbaxter added this to the 3.1.4 milestone Oct 1, 2024
@ryanjbaxter ryanjbaxter merged commit 99dd670 into spring-cloud:3.1.x Oct 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

task

Projects

No open projects
2023.0.4
Status: Done
2024.0.0-M2
Status: Done

Milestone

3.1.4

Development

Successfully merging this pull request may close these issues.

3 participants

@wind57 @ryanjbaxter @spring-cloud-issues