replace deprecated method #1751
Conversation
|
|
||
| private static final K3sContainer CONTAINER = new FixedPortsK3sContainer(DockerImageName.parse(Commons.RANCHER)) | ||
| .configureFixedPorts(EXPOSED_PORTS) | ||
| .withFileSystemBind(TEMP_FOLDER, TEMP_FOLDER) |
There was a problem hiding this comment.
the idea is this: withFileSystemBind is deprecated and the suggested solution is to use withCopyFileToContainer. There are numerous issue with that one though (there are some people complaining about this also, not just us). The first issue is that this is highly demanding memory wise, especially since we have lots of big images, so my first attempt was failing with OOM. There could be work-arounds, like copying tar files individually, but this is a huge problem in our case, because reuse for testcontainers would be broken (if needed will go into more details here, just let me know).
I've spent a few days here trying various things in a (now closed) PR, but the code was too involved and we would need a lot of changes to make it work. Instead, I decided to go to the "native" way to bound the directory, just like docker run -v ..., but from java code. This is not going to be removed or deprecated ever, so to me, we are good this way
3 participants
No description provided.