clean-up utilities for integration tests #1765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wind57
commented
Oct 16, 2024
| /** | ||
| * this path is generated by the pipeline of github actions. | ||
| */ | ||
| static final String TMP_IMAGES = "/tmp/docker/images"; |
There was a problem hiding this comment.
move some stuff to constants so that they are easier to manage
wind57
commented
Oct 16, 2024
| * | ||
| * @author wind57 | ||
| */ | ||
| final class FixedPortsK3sContainer extends K3sContainer { |
There was a problem hiding this comment.
create this one as a separate class with all variables it needs inside it
|
@ryanjbaxter this is ready, but contains "breaking changes" (public variables), but these are in test-support package, which is only supposed to be used for tests. So not sure how you feel about this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.