-
Notifications
You must be signed in to change notification settings - Fork 1.1k
clean-up a bit #1942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean-up a bit #1942
Conversation
| -Dhttp.keepAlive=false \ | ||
| -Dmaven.wagon.http.pool=false \ | ||
| -Dmaven.wagon.http.retryHandler.class=standard \ | ||
| -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have observed that we get some timeouts from time to time when we need something from maven central, seems that adding these options fixes the problem.
| </repository> | ||
| </repositories> | ||
| <pluginRepositories> | ||
| <pluginRepository> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why, but if I put this one here explicitly, it will not go to spring repositories for download, but use maven central
| </configuration> | ||
| </plugin> | ||
| <plugin> | ||
| <artifactId>maven-surefire-plugin</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove explicit versions and use the inherited ones
| <version>3.1.7-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <!-- override the ones coming from spring-cloud-build, until it is fixed other there --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
until (and if you agree) with this one : spring-cloud/spring-cloud-build#487, I am proposing to override the versions here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is merged now, can you remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right, removed.
| using: "composite" | ||
| steps: | ||
|
|
||
| - name: Disable man-db to make package install and removal faster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
about 1m improvement here because of this
Signed-off-by: wind57 <eugen.rabii@gmail.com>
| <name>${project.artifactId}</name> | ||
| <build> | ||
| <plugins> | ||
| <plugin> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop explicit java version
Signed-off-by: wind57 <eugen.rabii@gmail.com>
|
@ryanjbaxter some clean-up here and there, thank you. Ready to be looked at |
Signed-off-by: wind57 <eugen.rabii@gmail.com>
No description provided.