Skip to content

Conversation

@wind57
Copy link
Contributor

@wind57 wind57 commented Jul 1, 2025

No description provided.

@wind57 wind57 marked this pull request as draft July 1, 2025 19:13
Signed-off-by: wind57 <eugen.rabii@gmail.com>
wind57 added 3 commits July 2, 2025 07:25
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
-Dhttp.keepAlive=false \
-Dmaven.wagon.http.pool=false \
-Dmaven.wagon.http.retryHandler.class=standard \
-Dmaven.wagon.httpconnectionManager.ttlSeconds=120 \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have observed that we get some timeouts from time to time when we need something from maven central, seems that adding these options fixes the problem.

</repository>
</repositories>
<pluginRepositories>
<pluginRepository>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why, but if I put this one here explicitly, it will not go to spring repositories for download, but use maven central

</configuration>
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove explicit versions and use the inherited ones

<version>3.1.7-SNAPSHOT</version>
</parent>

<!-- override the ones coming from spring-cloud-build, until it is fixed other there -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

until (and if you agree) with this one : spring-cloud/spring-cloud-build#487, I am proposing to override the versions here

Copy link
Contributor

@ryanjbaxter ryanjbaxter Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is merged now, can you remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, removed.

using: "composite"
steps:

- name: Disable man-db to make package install and removal faster
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

about 1m improvement here because of this

Signed-off-by: wind57 <eugen.rabii@gmail.com>
<name>${project.artifactId}</name>
<build>
<plugins>
<plugin>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop explicit java version

Signed-off-by: wind57 <eugen.rabii@gmail.com>
@wind57 wind57 marked this pull request as ready for review July 2, 2025 08:36
@wind57
Copy link
Contributor Author

wind57 commented Jul 2, 2025

@ryanjbaxter some clean-up here and there, thank you. Ready to be looked at

Signed-off-by: wind57 <eugen.rabii@gmail.com>
@wind57 wind57 requested a review from ryanjbaxter July 15, 2025 07:52
@ryanjbaxter ryanjbaxter added this to the 3.1.7 milestone Jul 15, 2025
@ryanjbaxter ryanjbaxter merged commit 465838d into spring-cloud:3.1.x Jul 15, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this to Done in 2023.0.7 Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants