@NewSpan does not generate a new span Id for methods using Mono.subscriberContext

[nnanda2016]

I am using:

• Finchley.RELEASE release train
• Spring boot 2.0.3

If I use Mono.subscriberContext() in a method and annotate the method with @NewSpan(name="myMethod"), no new span ID is generated for that method.

Reference Repo: https://github.com/nnanda2016/springboot-sleuth-issue

The method com.demo.springboot.sleuth.UserApiHandler#getById2 is the buggy one I am talking about. No new span Id is generated if I invoke this method (URL to invoke this: curl -v http://localhost:5002/users/ids/U1).

If I remove Mono.subscriberContext(), everything is working fine as expected. Example method in this sample app is com.demo.springboot.sleuth.UserApiHandler#getById (URL to invoke this: curl -v http://localhost:5002/users/U1).

[kptfh]

@marcingrzejszczak Investigating this issue found that there is a bug in my recent pull request (didn't set new span in trace context). Will add tests and fix soon.

[kptfh]

@nnanda2016 Don't use Tracing.current().currentTraceContext().get().spanId() in your app. You should tracer.currentSpan().context().spanId() instead.
#1056 (comment)

[nnanda2016]

@kptfh I checked the review comments on #1056 and I will change the code as per your suggestion; however, does this usage cause this issue?

[marcingrzejszczak]

For sure it doesn't help ;) @kptfh has done some improvements in the way reactor stuff is handled so that should help

[nnanda2016]

oh okay...where can i see those details? I want to make code change n verify.

[marcingrzejszczak]

The whole discussion is happening in the PR (#1056). The previous changes were done here #1028

[nnanda2016]

So, looks like I have to upgrade the version to 2.0.1

[marcingrzejszczak]

Try with the latest 2.1.0 snapshots