Regression: server.servlet.context-path skips all endoints

[melloware]

Sprint Boot: 2.1.0
Spring Cloud: Greenwich.M3

Regression from this issue: #971

If you include a servlet context path like this:

server:
  port: 8080
  servlet:
      context-path: /melloware/

All endpoints are skipped and no Zipkin messages are sent. If you remove the context-path then all Zipkin messages are sent and received.

server:
  port: 8080

[melloware]

For others having this issue here is my workaround that seems to fix it. May not be elegant but it works.

    /**
     * Provide a list of URL patterns than can be skipped. This is a workaround to
     * https://github.com/spring-cloud/spring-cloud-sleuth/issues/1146 which can be removed once the bug is fixed
     * <p>
     * TODO: Remove once https://github.com/spring-cloud/spring-cloud-sleuth/issues/1146 is fixed
     *
     * @return the new SkipPatternProvider
     */
    @Bean
    protected SkipPatternProvider sleuthSkipPatternProvider() {
        final String defaultSkipPattern = SleuthWebProperties.DEFAULT_SKIP_PATTERN + "|/|/csrf|/webjars.*";
        final String contextPath = serverProperties.getServlet().getContextPath();
        if (StringUtils.isBlank(contextPath)) {
            LOG.info("Default Skip Pattern = {}", defaultSkipPattern);
            return () -> Pattern.compile(defaultSkipPattern);
        }

        final String[] defaultPatterns = StringUtils.split(defaultSkipPattern, '|');
        final List<String> patterns = new ArrayList<>(defaultPatterns.length);
        for (final String defaultPattern : defaultPatterns) {
            if (defaultPattern.startsWith("/")) {
                patterns.add(contextPath + defaultPattern);
            }
            else {
                patterns.add(defaultPattern);
            }
        }
        final String finalPattern = StringUtils.join(patterns, '|');
        LOG.info("Slueth Skip Pattern = {}", finalPattern);
        return () -> Pattern.compile(finalPattern);
    }