Resolves Circular Dependency issue #798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mminella
reviewed
Sep 16, 2021
| if (this.lineTokenizer != null) { | ||
| mapFlatFileItemReaderBuilder.lineTokenizer(this.lineTokenizer); | ||
| if (lineTokenizer != null) { | ||
| mapFlatFileItemReaderBuilder.lineTokenizer(lineTokenizer); |
There was a problem hiding this comment.
Why add the if statements? We previously depended upon the builder to validate that the state was valid.
There was a problem hiding this comment.
They were not required so , they can be null. So we need the null check.
There was a problem hiding this comment.
Again...the builder does that check. We don't do null checks on any of the other places we do this kind of thing (see here for example).
Makes sure that dependencies are passed in via parameters in bean declaraction vs. Autowiring refer to spring-projects/spring-batch#3991 resolves spring-cloud#797 Updated based on code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure that dependencies are passed in via parameters in bean declaraction vs. Autowiring
refer to spring-projects/spring-batch#3991
resolves #797