Check language task and set language (requires additional app) feature. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraffmann
requested changes
Jan 6, 2020
| } | ||
|
|
||
| override fun runTask2(device: IDevice) { | ||
| if (hasLocaleSetAsExpected(device)) { |
Collaborator
There was a problem hiding this comment.
You are missing the ! here.
You probably want to check if the system has NOT set the locale as expected, before you throw the exception.
| println("Device $deviceDetails setting language to $language.") | ||
| deviceWrapper.setLanguage(language) | ||
|
|
||
| Thread.sleep(1000) //external app changes language via UI, so we need to wait for it |
Collaborator
There was a problem hiding this comment.
Is there a possibility to avoid the Thread.sleep()? In case the device takes longer to change the system language, we throw an exception.
Is there another event we can react on?
If not, I am fine with this.
Comment on lines
25
to
30
| protected fun hasLocaleSetAsExpected(device: IDevice) :Boolean { | ||
| deviceWrapper = DeviceWrapper(device, outputReceiverProvider) | ||
| currentLanguage = deviceWrapper.getLanguage() | ||
|
|
||
| return currentLanguage != language | ||
| } |
Collaborator
There was a problem hiding this comment.
Whether the naming is stating the opposite of what the function is doing or the comparison operator should be == instead of !=.
paulinabls
force-pushed
the
feature/check_and_set_language_task
branch
from
5f395d8 to
a8eefd0
Compare
kraffmann
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.