Skip to content

Put builder class inside PortableFunctionCallingOptions #1874

@markpollack

Description

@markpollack

Currently the FunctionCallingOptionsBuilder is a separate class, it should be removed and instead a 'standard spring-ai' builder pattern be used inside PortableFunctionCallingOptions.

'standard spring-ai' builder at the moment is

  • no 'with' prefix on methods
  • check for passing in null values
  • for a 'simple' case like options, where there aren't going to be multiple implementations, there isn't a need for a builder interface.

Also rename PortableFunctionCallingOptions to DefaultFunctionCallingOptions

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions