Skip to content

Conversation

@jitokim
Copy link
Contributor

@jitokim jitokim commented Oct 31, 2024

Update documentation for property override precedence in ChatModel and EmbeddingModel configurations.

…d EmbeddingModel configurations.

Signed-off-by: jitokim <pigberger70@gmail.com>
@tzolov
Copy link
Contributor

tzolov commented Nov 3, 2024

Thanks @jitokim

@tzolov tzolov added this to the 1.0.0-M4 milestone Nov 3, 2024
@tzolov tzolov added the documentation Improvements or additions to documentation label Nov 3, 2024
@tzolov tzolov self-assigned this Nov 3, 2024
@tzolov tzolov merged commit cec7631 into spring-projects:main Nov 3, 2024
1 check passed
@markpollack
Copy link
Member

The changes to not seem correct, there are dedicated configuration prefix for the embedding models, see OpenAiEmbeddingProperties. What is the intention here? Embedding can have a different URL than chat, they have separate @ConfigurationProperties classes.

@jitokim
Copy link
Contributor Author

jitokim commented Nov 3, 2024

The changes to not seem correct, there are dedicated configuration prefix for the embedding models, see OpenAiEmbeddingProperties. What is the intention here? Embedding can have a different URL than chat, they have separate @ConfigurationProperties classes.

It seems to be understood as a comment on this note.

https://github.com/spring-projects/spring-ai/blame/560315ccfc4ac823d2d7c3cc2a1983e22e58992e/spring-ai-docs/src/main/antora/modules/ROOT/pages/api/embeddings/openai-embeddings.adoc#L110

The intention is that when using both the Embedding Model and the Chat Model together, the properties can be overridden individually.

Please let me know if there is any misunderstanding. Thank you.

@jitokim
Copy link
Contributor Author

jitokim commented Nov 3, 2024

@markpollack
Thanks for review.
I re-read the Chat Model documentation and understood your comment.
I'll revise it soon(If your intention is to remove the mention of chat model properties in the documentation for the embedding model).

However, in the case of using multiple accounts, the same explanation is provided for Mistralai, Minimax, Qianfan, Zhipuai, and OpenAI, which is why I didn't remove the explanation of the Chat Model properties from the documentation for Embedding Model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants