test: Add missing operator and edge case tests for AzureAiSearchFilterExpressionConverter #4467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rExpressionConverter Co-authored-by: Oleksandr Klymenko <alexanderklmn@gmail.com> Signed-off-by: Oleksandr Klymenko <alexanderklmn@gmail.com>
sunyuhan1998
approved these changes
Sep 25, 2025
|
@alxkm Thanks for the test coverage and @sunyuhan1998 thanks for the review. |
Willam2004
pushed a commit
to Willam2004/spring-ai
that referenced
this pull request
Oct 11, 2025
…rExpressionConverter (spring-projects#4467) Signed-off-by: Oleksandr Klymenko <alexanderklmn@gmail.com> Signed-off-by: 家娃 <guanjing.pangj@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds comprehensive test coverage for the
AzureAiSearchFilterExpressionConverterclass, focusing on missing operators and important edge cases that were not previously tested.Changes
New Test Cases Added:
testNullValue: Validates that null values in filter expressions are properly converted to Azure search syntax (eq null)testEmptyStringValue: Tests edge case of empty string values in filter expressionstestGtAndLt: Adds missing coverage for GT (greater than) and LT (less than) operatorstestNestedGroups: Tests complex nested group expressions with multiple levels of AND/OR combinationstestCaseSensitiveFieldNames: Verifies that field names with different cases are handled correctlyWhy These Tests Matter