Provide detailed Exception message when token count exceeds max #4835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxblum
added a commit
to jxblum/spring-ai
that referenced
this pull request
Nov 10, 2025
Closes spring-projects#4835 Signed-off-by: John Blum <jblum0@gmail.com>
jxblum
force-pushed
the
pr/TokenCountBatchingStrategy
branch
from
ea32d13 to
dc9955f
Compare
jxblum
added a commit
to jxblum/spring-ai
that referenced
this pull request
Nov 10, 2025
Closes spring-projects#4835 Signed-off-by: John Blum <jblum0@gmail.com>
jxblum
force-pushed
the
pr/TokenCountBatchingStrategy
branch
2 times, most recently
from
9e339b4 to
ca70f54
Compare
jxblum
added a commit
to jxblum/spring-ai
that referenced
this pull request
Nov 10, 2025
Closes spring-projects#4835 Signed-off-by: John Blum <jblum0@gmail.com>
jxblum
added a commit
to jxblum/spring-ai
that referenced
this pull request
Nov 10, 2025
Closes spring-projects#4835 Signed-off-by: John Blum <jblum0@gmail.com>
jxblum
force-pushed
the
pr/TokenCountBatchingStrategy
branch
from
ca70f54 to
1d52835
Compare
Closes spring-projects#4835 Signed-off-by: John Blum <jblum0@gmail.com>
jxblum
force-pushed
the
pr/TokenCountBatchingStrategy
branch
from
1d52835 to
d80fd64
Compare
ilayaperumalg
approved these changes
Nov 10, 2025
Member
ilayaperumalg
left a comment
ilayaperumalg
left a comment
There was a problem hiding this comment.
@jxblum thanks for the PR for the custom runtime exception when the token count exceeds max.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4835
As a developer, it would be really helpful to know when the (default) max token count is exceeded, what was the configured max value and what was the token count of the Document by ID that exceeded it.
This sort of diagnostic information should be given in any Exception to avoid having to resort to "debugging" to get it.