Make ToolCallAdvisor extensible with hook methods #5004
Merged
+213
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tzolov
commented
Dec 2, 2025
tzolov
commented
- Add protected doInitializeLoop, doBeforeCall, and doAfterCall hooks to allow subclasses to customize the tool calling loop behavior.
- Update Builder to support inheritance via self-referential generics.
- Add protected doInitializeLoop, doBeforeCall, and doAfterCall hooks to allow subclasses to customize the tool calling loop behavior. - Update Builder to support inheritance via self-referential generics. Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
Contributor
Author
|
This self-contained change can be ported to the 1.1.1 as well |
ilayaperumalg
approved these changes
Dec 2, 2025
tzolov
added a commit
that referenced
this pull request
Dec 2, 2025
- Add protected doInitializeLoop, doBeforeCall, and doAfterCall hooks to allow subclasses to customize the tool calling loop behavior. - Update Builder to support inheritance via self-referential generics. Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
Contributor
Author
|
backported to 1.1.x |
ericbottard
pushed a commit
to ericbottard/spring-ai
that referenced
this pull request
Dec 2, 2025
- Add protected doInitializeLoop, doBeforeCall, and doAfterCall hooks to allow subclasses to customize the tool calling loop behavior. - Update Builder to support inheritance via self-referential generics. Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.