Replace doesNotContains and Collectors.joining()

[rivkode]

• [refactor: Collectors.joining() -> String.join()]
• [fix : doesNotContain -> contains]

issue link

• PDFReader Test doesNotContains -> contain and Replace Collectors.joining() to String.join() #753

[rivkode]

Before

After

[markpollack]

the tests are passing with doesNotContain, the purpose of this test is to verify that the headers/footers were excluded. I don't understand how you see the failing test, the CI is green with respect to this test.

[rivkode]

I've tested the ExtractedTextFormatterTests class and it seems to be a "\n" problem.

Window: "\r\n"
Linux or Mac: "\n"

I think it's because System.lineSeparator() works in a different way between Windows and Linux or Mac OS.
I will figure it out how this code works on windows as well.

• Why are there different representations for newlines in Windows, Linux, and Mac?
• Getting the new line character without System.getProperty("line.separator")?

[rivkode]

It was my idea, but when I did some research into why the test was failing, I guess that the reason I was confused was because the name of the method was unclear.

How about changing the method name like this as below ?
If we've already discussed the method name, please ignore it

• classPathRead() -> excludeHeadersAndFootersPdfPages()
• classPathRead() -> withoutHeadersAndFooters()
• other

[tzolov]

Nothing to change