AMQP-846: Fix NPE (adviceChain) #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
requested changes
Nov 30, 2018
| @Nullable | ||
| public Advice[] getAdviceChain() { | ||
| return Arrays.copyOf(this.adviceChain, this.adviceChain.length); | ||
| return this.adviceChain == null ? null : Arrays.copyOf(this.adviceChain, this.adviceChain.length); |
There was a problem hiding this comment.
Why do we need copy here at all?
Since I see we do it anyway in the setAdviceChain().
Looks like this is an issue only for the current 2.1.x version
There was a problem hiding this comment.
Because the user could mutate the array but it won't take any effect because we built the proxy only during initialization.
| @Nullable | ||
| protected Advice[] getAdviceChain() { | ||
| return this.adviceChain; | ||
| return this.adviceChain == null ? null : Arrays.copyOf(this.adviceChain, this.adviceChain.length); |
There was a problem hiding this comment.
Right. And this is exactly what I commented above.
Why do we need to do this?
Is this something SonarQube complains, too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/AMQP-846