Add client secret POST authentication method support #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
Author
jgrandja
requested changes
Oct 26, 2020
Collaborator
jgrandja
left a comment
jgrandja
left a comment
There was a problem hiding this comment.
Thanks for the PR @anoopgarlapati. I left a couple of minor comments.
Also, I'm going to move this to the 0.1.0 release as the changes to the constructor in OAuth2ClientAuthenticationToken is a breaking change for a patch release. The 0.1.0 release allows major changes. Also, I'm pretty sure there will be more major API changes when you start working on Jwt auth.
...ork/security/oauth2/server/authorization/authentication/OAuth2ClientAuthenticationToken.java
Outdated
Show resolved
Hide resolved
.../security/oauth2/server/authorization/authentication/OAuth2ClientAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...ork/security/oauth2/server/authorization/authentication/OAuth2ClientAuthenticationToken.java
Outdated
Show resolved
Hide resolved
...mework/security/oauth2/server/authorization/web/ClientSecretPostAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
...n/java/org/springframework/security/oauth2/server/authorization/web/OAuth2EndpointUtils.java
Outdated
Show resolved
Hide resolved
jgrandja
added
type: enhancement
anoopgarlapati
force-pushed
the
gh-134
branch
2 times, most recently
from
a2bef8d to
69e56c4
Compare
Added support for client secret POST authentication method. Added validation of client authentication method when authenticating a client. Closes spring-projectsgh-134
anoopgarlapati
force-pushed
the
gh-134
branch
from
69e56c4 to
e1f491b
Compare
Contributor
Author
|
@jgrandja I have rebased this branch against master and resolved the merge conflicts. |
Collaborator
|
Thanks for all the updates @anoopgarlapati. This is now in master! |
doba16
pushed a commit
to doba16/spring-authorization-server
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for client secret POST authentication method.
Added validation of client authentication method when
authenticating a client.
Closes gh-134