Possibility to use an ApplicationContextInitializer in CommandLineJobRunner [BATCH-1917]

[spring-projects-issues]

Sebastien Lorber opened BATCH-1917 and commented

Hello,

On:
org.springframework.batch.core.launch.support.CommandLineJobRunner#start

We can't customize the initialization of the: org.springframework.context.support.ClassPathXmlApplicationContext

This may lead to the creation of a subclass of CommandLineJobRunner which will duplicate a lot of code from the parent method.

It would be nice if another method was providing an empty/default ApplicationContextInitializer that we could override, so that we could activate spring profiles or add additional propertysources without duplicating a lot of code that may lead to a framework version coupling.
This would be nice for users of Spring 3.1

---

Affects: 2.1.9

[spring-projects-issues]

Sebastien Lorber commented

Thanks.

It would also be nice to reduce the amount of static code in: CommandLineJobRunner#main

[spring-projects-issues]

Sebastien Lorber commented

By the way, on:
com.digiposte.batch.core.runner.CommandLineJobRunner#getJobExecutionsWithStatusGreaterThan

There is a nullpointer when the jobIdentifier provided (in my case as JVM argument) is invalid, on line:
"if (jobExecution.getStatus().isGreaterThan(minStatus))"
It would be nice to have a better exception message (or a log + empty collection?)

[spring-projects-issues]

Dave Syer commented

The ApplicationContextFactory hierarchy in Spring Batch is being re-worked to support Spring 3 features, so that is probably the best place to attack the original feature request.

Please try to stick to 1 JIRA ticket per issue.

[spring-projects-issues]

Thomas Recloux commented

This feature would be really helpful for me.
I am ready to help/implement the feature, would you like a pull request for this feature ?

[spring-projects-issues]

Michael Minella commented

Pull requests are always appreciated. Please be sure to sign the Contributor's Agreement here: https://support.springsource.com/spring_committer_signup

[spring-projects-issues]

Thomas Recloux commented

I was thinking to use a system property to specify the context initializer classes, sounds good ?

[spring-projects-issues]

Michael Minella commented

Since we're talking about the CommandLineJobRunner, why not a command line argument: -contextInitializer=io.spring.MyInitializer

[spring-projects-issues]

Michael Minella commented

Given that I'd expect most developers using Batch these days are executing their jobs via Spring Boot, I'm not sure this makes a lot of sense anymore. Moving it out of 4.0 unless anyone objects.