Skip to content

Add the constructor with Callable to CallableTaskletAdapter for convenience #3831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add the constructor with Callable to CallableTaskletAdapter for convenience #3831

wants to merge 1 commit into from

Conversation

@benelog
Copy link
Contributor

@benelog benelog commented Jan 15, 2021 •
edited
Loading

This PR adds the constructor with a Callable<RepeatStatus> parameter to CallableTaskletAdapter.
It makes CallableTaskletAdapter more convenient.

AS-IS:

    var tasklet = new CallableTaskletAdapter();
    tasklet.setCallable(callable);

TO-BE:

    var tasklet = new CallableTaskletAdapter(callable);

@benelog benelog force-pushed the add-CallableTaskletAdapter-constructor branch 3 times, most recently from d676bb4 to 1c705c4 Compare January 15, 2021 23:54
@fmbenhassine fmbenhassine added the status: waiting-for-triage Issues that we did not analyse yet label Jan 21, 2021
benelog
benelog commented Jan 24, 2021
View reviewed changes
...h-core/src/main/java/org/springframework/batch/core/step/tasklet/CallableTaskletAdapter.java
*/
public CallableTaskletAdapter(Callable<RepeatStatus> callable) {
setCallable(callable);
afterPropertiesSet();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I referenced the constructor of JdbcTemplate, which also provides both setter and constructor injection.

https://github.com/spring-projects/spring-framework/blob/master/spring-jdbc/src/main/java/org/springframework/jdbc/core/JdbcTemplate.java#L172

@fmbenhassine fmbenhassine added in: core pr-for: feature and removed status: waiting-for-triage Issues that we did not analyse yet labels Mar 15, 2021
@benelog benelog force-pushed the add-CallableTaskletAdapter-constructor branch from 1c705c4 to bbdd00c Compare March 13, 2023 15:32
@benelog
Copy link
Contributor Author

benelog commented Mar 13, 2023

@fmbenhassine
I resolved the conflicts with main branch now. Could you please review this PR again?

fmbenhassine pushed a commit that referenced this pull request Sep 14, 2023
@benelog @fmbenhassine
Add constructor with Callable to CallableTaskletAdapter
31955a0 
Issue #3831
@fmbenhassine
Copy link
Contributor

LGTM. Rebased and merged as 31955a0. Thank you for your contribution!

@fmbenhassine fmbenhassine added this to the 5.1.0-M3 milestone Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

in: core pr-for: feature

Projects

None yet

Milestone

5.1.0-M3

Development

Successfully merging this pull request may close these issues.

2 participants

@benelog @fmbenhassine