Skip to content

Conversation

thelmstedt
Copy link

Backported "React to dependency management plugin rather than always
applying it" from the 2.x branch. We don't have tests in this branch so
they haven't been pulled across.

Backported "React to dependency management plugin rather than always
applying it" from the 2.x branch. We don't have tests in this branch so
they haven't been pulled across.
@pivotal-issuemaster
Copy link

@thelmstedt Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@thelmstedt Thank you for signing the Contributor License Agreement!

@wilkinsona
Copy link
Member

wilkinsona commented Oct 25, 2017

Thanks, but removing the logic that applies the dependency management plugin automatically would be a breaking change which, therefore, cannot be made in 1.5.x.

@wilkinsona wilkinsona closed this Oct 25, 2017
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 25, 2017
@thelmstedt
Copy link
Author

thelmstedt commented Oct 25, 2017

Ouch - can this be documented in big red blinking letters somewhere? I was extremely surprised that a development-time tool influenced my dependency versions at all - let alone in a way which breaks native gradle dependency overrides.

What if it was configurable, instead of the default?

@wilkinsona
Copy link
Member

It's already documented along with a section describing how to override the versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: declined A suggestion or change that we don't feel we should currently apply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants