Skip to content

Add statsd graceful shutdown support #42343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add statsd graceful shutdown support #42343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...oot/actuate/autoconfigure/metrics/export/statsd/StatsdMetricsExportAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import io.micrometer.core.instrument.Clock;
import io.micrometer.statsd.StatsdConfig;
import io.micrometer.statsd.StatsdMeterRegistry;
import jakarta.annotation.PreDestroy;

import org.springframework.boot.actuate.autoconfigure.metrics.CompositeMeterRegistryAutoConfiguration;
import org.springframework.boot.actuate.autoconfigure.metrics.MetricsAutoConfiguration;
Expand Down Expand Up @@ -59,4 +60,8 @@ public StatsdMeterRegistry statsdMeterRegistry(StatsdConfig statsdConfig, Clock
return new StatsdMeterRegistry(statsdConfig, clock);
}

@PreDestroy
public void destroy(StatsdMeterRegistry statsdMeterRegistry) {
statsdMeterRegistry.close();
}
}
Copy link
Contributor

@mdeinum mdeinum Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work as @PreDestroy should not have any arguments (See https://jakarta.ee/specifications/platform/9/apidocs/jakarta/annotation/predestroy).

Finally as the StatsdMeterRegistry has a close method that should already be registered automatically as a pre-destroy method. For this see the @Bean.

So the solution to the problem lies not in adding additional annotations but probably elsewhere.

Copy link
Member

@wilkinsona wilkinsona Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mdeinum. I was just going to comment with the same analysis.

@popotec can you please open an issue so that we can investigate further? Seeing the stack trace of the exception when bean creation is attempted during shutdown may be enough for us to figure out the cause.