-
Notifications
You must be signed in to change notification settings - Fork 41.6k
Add AWS ECS to cloud platforms #47482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the suggestion. What about EC2 (and any other deployment option other than ECS and Lambda that there may be now or in the future)? |
|
If EC2 is the underlying ECS runtime, that gets picked up using
|
|
We need to consider more than |
|
I see. In that case, I can update this PR to focus on ECS - that can be detected quite accurately (using I'm not sure detecting AWS Lambda using similar mechanism is worth it, as lambdas are quite coupled to the runtime either way. |
This commit adds support for detecting AWS ECS to `CloudPlatform`. The detection is based on presence of `AWS_EXECUTION_ENV` environment variable with value starting with `AWS_ECS`. Signed-off-by: Vedran Pavic <vedran@vedranpavic.com>
605797a to
2340571
Compare
This commit adds support for detecting AWS ECS to `CloudPlatform`. The detection is based on presence of `AWS_EXECUTION_ENV` environment variable with value starting with `AWS_ECS`. See gh-47482 Signed-off-by: Vedran Pavic <vedran@vedranpavic.com>
This commit adds support for detecting AWS ECS to
CloudPlatform. The detection is based on presence ofAWS_EXECUTION_ENVenvironment variable with value starting withAWS_ECS.Related resources: