Implement tests for HttpClientSettingsPropertyMapper #48145
Closed
+107
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive tests for the HttpClientSettingsPropertyMapper class that was previously disabled with a TODO comment. The tests cover: - Mapping with null properties - Mapping individual properties (redirects, connectTimeout, readTimeout, SSL bundle) - Mapping all properties together - Using base settings for missing properties - Error handling when SSL bundles are unavailable Signed-off-by: Steve Armstrong <stevearmstrong-dev@users.noreply.github.com>
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
added
type: task
snicoll
pushed a commit
that referenced
this pull request
Nov 17, 2025
See gh-48145 Signed-off-by: Steve Armstrong <stevearmstrong-dev@users.noreply.github.com>
snicoll
added a commit
that referenced
this pull request
Nov 17, 2025
Member
|
Thanks @stevearmstrong-dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive tests for the HttpClientSettingsPropertyMapper class that was previously disabled with a TODO comment. The tests cover: