Cannot have repo implementation in different namespace [DATACMNS-1230]

[spring-projects-issues]

bojan vukasovic opened DATACMNS-1230 and commented

I cannot move repo implementation in different namespace than where I define interface even if I specify component scan for mulitple namespaces with

@EnableElasticsearchRepositories(basePackages = {"com.a", "com.b"})

.

The problem lies in RepositoryBeanDefinitionBuilder where

public Iterable<String> getBasePackages() {
            return Collections.singleton(ClassUtils.getPackageName(fragmentInterfaceName));
        }

should be

public Iterable<String> getBasePackages() {
            return configuration.getBasePackages();
        }

Is there specific reason for this kind of implementation?

---

No further details from DATACMNS-1230

[spring-projects-issues]

Oliver Drotbohm commented

That's by design and has been tightened with DATACMNS-1172. Repository implementations need to stay in the same package (or a sub-package) of the actual repository interface

[spring-projects-issues]

bojan vukasovic commented

is it possible to have this setting configurable? i would like to have interface definitions in my doman namespace and all implementations in external infastructure namespace

[spring-projects-issues]

Mark Paluch commented

You can register implementations as beans with their default name so registration will pick them up instead of scanning. Works only for the 1.x scheme MyRepositoryImpl, not for repository fragments

[spring-projects-issues]

bojan vukasovic commented

Do you mean I have to use commons 1.x? Is this an example of what you are talking about:

import com.app.domain.repo

public interface ARepo extends ElasticsearchRepository<A, String>, CustomizedARepo {
}

public interface CustomizedARepo {
    List<A> makeSearch(int x);
}

import com.app.infrastr.repo

public class CustomizedARepoImpl implements CustomizedARepo {

    private ElasticsearchTemplate elasticsearchTemplate;

    public CustomizedARepoImpl(ElasticsearchTemplate elasticsearchTemplate) {
        this.elasticsearchTemplate = elasticsearchTemplate;
    }

    @Override
    public List<A> makeSearch(int x){ return null; }
}

@Configuration
@EnableElasticsearchRepositories(basePackages = {"com.app.domain.repo", "com.app.infrastr.repo"})
public class Config{
    @Bean
    public ARepo customizedARepoImpl (ElasticsearchTemplate template){
        return (ARepo)new CustomizedARepoImpl (template);
    }
}

I tried all variations but still get

AnnotationConfigWebApplicationContext.log: Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'aRepo': Invocation of init method failed; nested exception is org.springframework.data.mapping.PropertyReferenceException: No property makeSearch found for type A!

[mp911de]

Workaround verified:

@Bean
public SomeFragmentImpl myEntityRepositoryImpl() {
	return new SomeFragmentImpl();
}

public interface MyEntityRepository  extends CrudRepository<MyEntity, Long>, SomeFragment {}