Skip to content

Conversation

pulse00
Copy link
Contributor

@pulse00 pulse00 commented Feb 21, 2019

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Copy link
Contributor

@xhaggi xhaggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest some minor changes. The rest looks good. Thank you.

@pulse00
Copy link
Contributor Author

pulse00 commented Mar 4, 2019

@xhaggi the build seems to hang https://ci.spring.io/builds/61411

Copy link
Contributor

@xhaggi xhaggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll shove it in next week.

@pulse00
Copy link
Contributor Author

pulse00 commented Mar 11, 2019

Looks good. I'll shove it in next week.

super, thanks.

xhaggi pushed a commit that referenced this pull request Mar 13, 2019
@xhaggi xhaggi closed this Mar 13, 2019
xhaggi pushed a commit that referenced this pull request Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants