Skip to content
This repository was archived by the owner on Oct 22, 2025. It is now read-only.

Conversation

yozaner1324
Copy link

@yozaner1324 yozaner1324 commented Feb 12, 2020

  • You have read the Spring Data contribution guidelines.
  • You created a JIRA ticket in the bug tracker for the project.
  • You formatted the code according to the source code style provided here and have specifically applied them to your changes. Do not submit any formatting related changes.
  • You submitted test cases (Unit or Integration Tests) backing your changes.
  • You added yourself as the author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
  • If applicable, you have complied with and taken steps necessary to report any security vulnerabilities at Pivotal Security Reporting.

@yozaner1324 yozaner1324 requested a review from jxblum February 12, 2020 00:39
@jxblum jxblum self-assigned this Feb 26, 2020
@jxblum jxblum added the bug label Feb 26, 2020
jxblum added a commit to jxblum/spring-data-geode that referenced this pull request Feb 28, 2020
@jxblum jxblum closed this in 513afaa Feb 28, 2020
@jxblum
Copy link
Contributor

jxblum commented Feb 28, 2020

Re-opening PR since this is not complete.

  • Need to refactor the functionality supporting results from all servers.
  • Need to include (unignore) the test class.

@jxblum jxblum reopened this Feb 28, 2020
Copy link
Contributor

@jxblum jxblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all, nice work; really good test case. Once these changes are made, then we can back port this to SD Moore.

@jxblum jxblum added in-progress Work is in-progress. waiting-for-feedback Waiting for feedback. labels Feb 28, 2020
@yozaner1324 yozaner1324 requested a review from jxblum March 13, 2020 16:23
jxblum added a commit to jxblum/spring-data-geode that referenced this pull request Mar 16, 2021
jxblum pushed a commit to jxblum/spring-data-geode that referenced this pull request Mar 16, 2021
@jxblum jxblum closed this in bfe0a6c Mar 17, 2021
jxblum pushed a commit to jxblum/spring-data-geode that referenced this pull request Mar 17, 2021
jxblum added a commit to jxblum/spring-data-geode that referenced this pull request Mar 17, 2021
jxblum pushed a commit to jxblum/spring-data-geode that referenced this pull request Mar 17, 2021
jxblum pushed a commit to jxblum/spring-data-geode that referenced this pull request Mar 17, 2021
jxblum added a commit to jxblum/spring-data-geode that referenced this pull request Mar 17, 2021
jxblum pushed a commit to jxblum/spring-data-geode that referenced this pull request Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug in-progress Work is in-progress. waiting-for-feedback Waiting for feedback.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants