-
Notifications
You must be signed in to change notification settings - Fork 619
Description
I found several tests that fail on 4.4
org.springframework.data.neo4j.integration.issues.IssuesIT#hydrateProjectionReachableViaMultiplePathsorg.springframework.data.neo4j.integration.issues.IssuesIT#asdf
There's a class cast exception happening in the template support and I think that should be fixed.
I am assigning you as you wrote both the test and last time touch the element id support in that area.
Some other test use elementId() verbatim during setup. I disabled those on 4.4 and I think they can safely stay that way.
In addition I missed the change to the CypherGenerator in which the elementId function is modified in the templates. This is problematic, as the generator is a singleton. As such, testing will fail if you run for example TemplateExampleTests against Neo4j 4.4 first, and than CypherGeneratorTests, the latter relying on the fact that it has been expressed "Cypher 5" and "can use element id".