Polish for 2640 - Reordering 'static' and 'final' modifiers #2644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the Java Language Specification (Java 17; https://docs.oracle.com/javase/specs/jls/se17/html/jls-8.html#jls-8.3.1), 'static' should appear before 'final'. This is also consistent with source code analysis tools, like Checkstyle, rules: https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/modifier/ModifierOrderCheck.html. See spring-projects#2640
jxblum
changed the title
Additionally, applied Java 17 syntax, cleaned up compiler warnings, and edited Javadoc. Closes spring-projects#2644 Original pull request: spring-projects#2640
mp911de
added a commit
that referenced
this pull request
Jul 18, 2023
Make fields final where possible. Reintroduce end of line comment markers to avoid reformatting into unreadable format. Replace HashSet per command instance with String to reduce memory footprint. Tweak Javadoc wording to represent what we actually expect. Reorder methods. See #2640 Original pull request: #2644
mp911de
added a commit
that referenced
this pull request
Jul 18, 2023
Make fields final where possible. Reintroduce end of line comment markers to avoid reformatting into unreadable format. Replace HashSet per command instance with String to reduce memory footprint. Tweak Javadoc wording to represent what we actually expect. Reorder methods. See #2640 Original pull request: #2644
mp911de
added a commit
that referenced
this pull request
Jul 18, 2023
Make fields final where possible. Reintroduce end of line comment markers to avoid reformatting into unreadable format. Replace HashSet per command instance with String to reduce memory footprint. Tweak Javadoc wording to represent what we actually expect. Reorder methods. See #2640 Original pull request: #2644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2640
Additionally, and more generally, for the changed classes, I also applied Java 17 syntax where applicable, cleaned up compiler warnings and edited Javadoc.