Skip to content

Annotate ValueOperations.get(…) methods with @Nullable. #3244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Annotate ValueOperations.get(…) methods with @Nullable. #3244

wants to merge 2 commits into from

Conversation

@onobc
Copy link
Contributor

@onobc onobc commented Oct 24, 2025 •
edited
Loading

This PR annotates the return values of several GET related ValueOperations methods with @Nullable to reflect the fact that null values are returned when non-existent keys are passed in.

Resolves: #3223

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

onobc added 2 commits October 23, 2025 19:24
@onobc
GH-3223 - Prepare branch
e429156
@onobc
Annotate ValueOperations.get(…) methods with @Nullable.
444d764 
This commit annotates the return values of several GET related `ValueOperations` methods with `@Nullable` to reflect the fact that null values are returned when non-existent keys are passed in.

Resolves: #3223
Signed-off-by: Chris Bono <chris.bono@broadcom.com>
@onobc onobc requested a review from mp911de October 24, 2025 00:25
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 24, 2025
mp911de pushed a commit that referenced this pull request Oct 24, 2025
@onobc @mp911de
Annotate ValueOperations.get(…) methods with @Nullable.
b3b471d 
This commit annotates the return values of several GET related `ValueOperations` methods with `@Nullable` to reflect the fact that null values are returned when non-existent keys are passed in.

Resolves: #3223
Original pull request: #3244
Signed-off-by: Chris Bono <chris.bono@broadcom.com>
mp911de added a commit that referenced this pull request Oct 24, 2025
@mp911de
Polishing.
eca5ac5 
Enforce non-nullability of serializers when actually using these.

See: #3223
Original pull request: #3244
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 24, 2025
@mp911de mp911de added this to the 4.0 GA (2025.1.0) milestone Oct 24, 2025
@mp911de mp911de added type: enhancement A general enhancement and removed type: bug A general bug labels Oct 24, 2025
@mp911de
Copy link
Member

mp911de commented Oct 24, 2025

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Oct 24, 2025
@mp911de mp911de deleted the issue/GH-3223 branch October 24, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mp911de mp911de Awaiting requested review from mp911de

Assignees

No one assigned

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

4.0 RC2 (2025.1.0)

Development

Successfully merging this pull request may close these issues.

ValueOperations.get(…) methods should be annotated with @Nullable

4 participants

@onobc @mp911de @spring-projects-issues