Skip to content

Conditions with SimpleExpressions get properly rendered. #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Conditions with SimpleExpressions get properly rendered. #1015

wants to merge 2 commits into from

Conversation

@schauder
Copy link
Contributor

@schauder schauder commented Jul 22, 2021 •
edited
Loading

This is rebased onto #1014, please review that first.

Closes #1009

@schauder schauder requested a review from gregturn July 22, 2021 09:48
schauder added a commit that referenced this pull request Jul 30, 2021
@schauder
Conditions with SimpleExpressions get properly rendered.
7c7c826 
This commit contains just a test to verify this.
The actual fix happened as part of #1018.

Closes #1009.
Original pull request #1015
See #1018
schauder added a commit that referenced this pull request Jul 30, 2021
@schauder
Polishing.
c9289ff 
See #1009
Original pull request #1015
@schauder schauder force-pushed the issue/1009-join-with-just branch from 6ec8d62 to c9289ff Compare July 30, 2021 06:57
@gregturn
Copy link
Contributor

gregturn commented Aug 26, 2021

Again, looks like a lot of the same from #1018 and #1014.

@schauder @mp911de
1009-join-with-just - Prepare branch
e4ee677
@schauder @mp911de
Conditions with SimpleExpressions get properly rendered.
69d101f 
This commit contains just a test to verify this.
The actual fix happened as part of #1018.

Closes #1009.
Original pull request #1015
See #1018
@mp911de mp911de force-pushed the issue/1009-join-with-just branch from c9289ff to 69d101f Compare September 28, 2021 13:03
@mp911de mp911de added the type: task A general task label Sep 28, 2021
mp911de pushed a commit that referenced this pull request Sep 28, 2021
@schauder @mp911de
Conditions with SimpleExpressions get properly rendered.
520134d 
This commit contains just a test to verify this.
The actual fix happened as part of #1018.

Closes #1009.
Original pull request #1015
See #1018
mp911de added a commit that referenced this pull request Sep 28, 2021
@mp911de
Polishing.
660a44e 
See #1009
Original pull request: #1015.
@mp911de mp911de added this to the 2.3 RC1 (2021.1.0) milestone Sep 28, 2021
@mp911de
Copy link
Member

mp911de commented Sep 28, 2021

That's merged and polished now.

@mp911de mp911de closed this Sep 28, 2021
@mp911de mp911de deleted the issue/1009-join-with-just branch September 28, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregturn gregturn Awaiting requested review from gregturn

Assignees

@gregturn gregturn

Labels

type: task A general task

Projects

None yet

Milestone

2.3 RC1 (2021.1.0)

Development

Successfully merging this pull request may close these issues.

SelectBuilder's .join(...).on(X).equals(Y) assumes X/Y are *not* Expressions.just(...) expressions

4 participants

@schauder @gregturn @mp911de