[DATAJDBC-488] Resolves an issue with deadlocks in the order of update execution. #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
pushed a commit
that referenced
this pull request
Feb 21, 2020
The previous process of deleting referencing entities, updating the root and then inserting referencing entities hat the potential of causing deadlocks. When one process didn't obtain a lock on delete because there wasn't anything to delete root and referencing entities got locks in opposite order, which is a classical cause for deadlocks. Original pull request: #191.
schauder
added a commit
that referenced
this pull request
Feb 21, 2020
JdbcRepositoryConcurrencyIntegrationTests now only runs with MySql instead of always with MySql. Also modified it to not use sleep. Copyright header added. Formatting. Original pull request: #191.
schauder
pushed a commit
that referenced
this pull request
Feb 21, 2020
The previous process of deleting referencing entities, updating the root and then inserting referencing entities hat the potential of causing deadlocks. When one process didn't obtain a lock on delete because there wasn't anything to delete root and referencing entities got locks in opposite order, which is a classical cause for deadlocks. Original pull request: #191.
schauder
added a commit
that referenced
this pull request
Feb 21, 2020
JdbcRepositoryConcurrencyIntegrationTests now only runs with MySql instead of always with MySql. Also modified it to not use sleep. Copyright header added. Formatting. Original pull request: #191.
|
That is polished and merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DATAJDBC-488
https://github.com/spring-projects/spring-data-jdbc/pull/191/files#diff-96c4ebdaa99aec19171b092995e4e765R70