RequestContextHolder - misleading Javadoc and exception

[lrozenblyum]

org.springframework.web.context.request.RequestContextHolder documents that org.springframework.web.servlet.DispatcherServlet exposes it by default. However it's not true:

DispatcherServlet has removed that fuctionality since d950b56

Thus the exception message used inside org.springframework.web.context.request.RequestContextHolder.currentRequestAttributes() is also misleading.

[sbrannen]

DispatcherServlet has removed that fuctionality since d950b56

In d950b56, the code related to RequestContextHolder was moved from DispatcherServlet to FrameworkServlet which is the superclass of DispatcherServlet.

Thus, the functionality was not "removed" but rather just moved.

In other words, a DispatcherServlet still exposes the current request (by registering ServletRequestAttributes with the RequestContextHolder).

In light of that, I am closing this issue.

[lrozenblyum]

I'm sorry @sbrannen. Didn't spot it in FrameworkServlet