Need for SimpleJdbcUpdate [SPR-4691]

[spring-projects-issues]

Ramkumar Krishnan opened SPR-4691 and commented

It would be great if we have something like SimpleJdbcUpdate similar to SimpleJdbcInsert. It should take map<column names ,values> and another map<updateColumnNames, values> as parameters and it should update table based on that.
The column names in the second map should appear in the WHERE clause. There should be an overloaded method also which takes only one String(column name) which should appear in the WHERE clause.

---

Affects: 2.5.3

20 votes, 22 watchers

[spring-projects-issues]

Donal Murtagh commented

I'd really like to see this too. The reporter of this issue has outlined a possible API for performing updates, but of course it should also support deleting rows.

A possible argument against this feature is the existence of the SqlUpdate class. However, the usage of this class (see section 11.6.3 of the reference document) really lacks the simplicity that makes SimpleJdbcInsert so appealing.

[spring-projects-issues]

Florent Paillard commented

I did a SimpleJdbcUpdate for a project and released it on Github. Feel free to use it and to send me any feedback.

https://github.com/florentp/spring-simplejdbcupdate

[spring-projects-issues]

Adib Saikali commented

Florent maybe you should submit your project as pull request to Spring now that Spring is on github.

[spring-projects-issues]

Juergen Hoeller commented

A pull request would indeed be welcome! We'll try to include a SimpleJdbcUpdate class for Spring Framework 4.2 now, after all those years...

Juergen

[spring-projects-issues]

Florent Paillard commented

Hi

I'll try to submit the pull request in the coming days. I have to make a few minor changes to match all Spring coding and committing guide lines.

Otherwise, fell free to reuse what I've done on my github repo (mentioned above). Some work have been done by another Spring Framewok user (dr3s). He should agree and be happy to share his code as well.

BR

[spring-projects-issues]

Stéphane Nicoll commented

Florent, how about this PR? I'd rather have it that way so that you get contributions for that code. I can also use the code on your github repo and update it to match our style but I'd commit that under my name then.

[spring-projects-issues]

Florent Paillard commented

Hello Stéphane,

I'm working on it. Do you have a due date for the PR?

JDBC classes changed since I developed the SimpleJdbcUpdate on my github repo. I have to adapt a few things and I think I will need to make changes to org.springframework.jdbc.core.metadata.TableMetaDataContext. It's my first Spring Framework PR, where should I discuss these changes?

Thanks

[spring-projects-issues]

Stéphane Nicoll commented

Before May 10th would be nice, especially if we have to iterate over it (it really depends how large it is).

Don't worry too much about your first PR: there is some documentation to help you and we're definitely there to help.I am more interested by a good design, the tests and the javadoc. If the coding standard are not aligned, I can take care of that to show you concretely what we're expecting. Thanks again!

[spring-projects-issues]

Stéphane Nicoll commented

Florent, any news?

[spring-projects-issues]

Paulo Heck commented

I'm uses this SimpleJdbcUpdate is very nice!

[spring-projects-issues]

Rob Platt commented

Anyone working on this/planning to work on this?

If not, I suggest to fork Florent's github repo, make any necessary changes, and make a a PR request initially to Florent's original github project. That way all he has to do is the PR to Spring itself and he can still get the commit attribution.

If he is not contactable to do do that, can I make the PR from my fork to Spring? Presumably Florent can still be attributed even if not for the commit? It would be a great shame if he couldn't. But I'd really like to see this closed down in Spring 4.3!

[spring-projects-issues]

Stéphane Nicoll commented

Rob, check directly with Florent. As long as you guys submit a PR and sign the CLA we'll be fine. Florent Paillard, any progress about this?

[spring-projects-issues]

Florent Paillard commented

I worked a bit on it few months ago. I realized 2 things:

• Spring JDBC has changed since I wrote the Simple JDBC update so an important rewrite is needed I think. Mostly in my code but also in Spring itself
• I don't have enough time to rewrite and make necessary adjustments myself.

Taking into account this considerations, I won't take offence if you fork the repo and get the commit attribution. I would have been happy to help but it's currently not compatible with my agenda.

[spring-projects-issues]

Rob Platt commented

Hi Florent, that's completely understandable. What I'll do is try to make any necessary adjustments and then submit a PR for your github repo first. I have it working but maybe there is something I have missed, so an opportunity to have it looked at would be cool, if you get later time... I also don't mind doing this rework step but you do the submission to spring -- I'll let you know nearer the time and you can make a call, no need to commit now!

And, a big thanks for all your work creating these helpful classes :-)

[spring-projects-issues]

Sanghyuk Jung commented

I submitted PR to upgrade versions of Spring libraries for Florent 's SimpleJdbcUpdate.

florentp/spring-simplejdbcupdate#3

It works on Spring 4.2.x. But this library has duplicated codes with spring-jdbc.

IMHO, it needs refactoring to port to spring-jdbc.

• Merge Florent 's TableMetaDataContext with original TableMetaDataContext
• Extract common super class for AbstractJdbcUpdate, AbstractJdbcInsert ( e.g: SingleTableSqlSupport )
• Rename Operator to more specific name. (e.g: ComparisonOperator) It conflicts with org.springframework.expression.spel.ast.Operator

This task may be suitable for maintainers of spring-framework, because it affects AbstractJdbcInsert, TableMetaDataContext.

If maintainers still consider it 'Contributions Welcome', I am able to submit PR including refactorings