Skip to content

Testing docs should refer to ExecutionGraphQlService instead of GraphqlService #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Testing docs should refer to ExecutionGraphQlService instead of GraphqlService #877

wants to merge 1 commit into from

Conversation

nilshartmann
Copy link
Contributor

I think it should be ExecutionGraphQlService in the docs, not GraphqlService

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 16, 2024
@rstoyanchev rstoyanchev self-assigned this Jan 26, 2024
@rstoyanchev rstoyanchev added this to the 1.2.5 milestone Jan 26, 2024
@rstoyanchev rstoyanchev added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 26, 2024
rstoyanchev
rstoyanchev approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for spotting that.

@rstoyanchev rstoyanchev changed the title Testing docs: ExecutionGraphQlService instead of GraphqlService Testing docs should refer to ExecutionGraphQlService instead of GraphqlService Jan 26, 2024
rstoyanchev pushed a commit that referenced this pull request Jan 26, 2024
@nilshartmann @rstoyanchev
ExecutionGraphQlService instead of GraphqlService
b37a06b 
See gh-877
@rstoyanchev
Copy link
Contributor

This has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rstoyanchev rstoyanchev rstoyanchev approved these changes

Assignees

@rstoyanchev rstoyanchev

Labels

type: task A general task

Projects

None yet

Milestone

1.2.5

Development

Successfully merging this pull request may close these issues.

3 participants

@nilshartmann @rstoyanchev @spring-projects-issues