Custom GrpcClientObservationConvention is not autowired

[suliao]

I tried to customize grpc client metrics to remove "net_peer_name", which cause NPE for my use case. But it did not work. My custom GrpcClientObservationConvention bean is not wired on. GrpcClientObservationAutoConfiguration.java did not wired on GrpcClientObservationConvention, and pass to ObservationGrpcClientInterceptor

[dsyer]

The GrpcClientObservationConvention is not applied to the autoconfigured ObservationGrpcClientInterceptor (it looks like by design) - you would have to set up your own interceptor. We could change that I guess if you confirm that it works. How does this work with other Micrometer integations? Maybe only one custom convention is too restrictive anyway?

[Subhojit-Dey1234]

I tried like this

@Bean
    GreetingServiceGrpc.GreetingServiceBlockingStub greetingStub(GrpcChannelFactory factory,
                                                                 ObservationRegistry observationRegistry) {
        ObservationGrpcClientInterceptor obj = new ObservationGrpcClientInterceptor(observationRegistry);
        DefaultGrpcClientObservationConvention defaultGrpcClientObservationConvention = new CustomGrpcClientObservationConvention();
        obj.setCustomConvention(defaultGrpcClientObservationConvention);
        return GreetingServiceGrpc.newBlockingStub(
                ManagedChannelBuilder.forAddress("localhost",42069)
                        .usePlaintext()
                        .intercept(obj)
                        .build()
        );
    }

I am able to remove the net_peer_name from the tags. Please have a look if you find it helpful.

[suliao]

Yes. This helped. Thanks. I used other client, like spring webclient. Custom observationConvertion can work out of the box. No need to create my own bean.