Add sample for kotlin stubs server #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas McKernan <tmeaglei@gmail.com>
Signed-off-by: Thomas McKernan <tmeaglei@gmail.com>
mckernant1
changed the title
Signed-off-by: Thomas McKernan <tmeaglei@gmail.com>
|
Tests pass now with |
|
This looks useful even without the kotlin sample, but I'm happy to have that as well. Can you rebase on main to pick up a change in the GitHub action config? It will be interesting to see if the fix for #143 can be reverted after this change. |
|
Looks like this is still failing on some gpg issue? |
|
Yeah, I don't understand. I'll try and work out what happened. |
|
Sorry. You're going to have to rebase and push again to help me debug this. It won't work yet, but I'm iterating. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Should not be merged until stubs issue is fixed. Tests is currently fail, waiting on a fix from kotlin stubs library grpc/grpc-kotlin#646.
This adds tests for kotlin-stubs based server setup. Related to issue #164