Add ability to filter services from being bound to server factories (collaboration) #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for filtering the server-side global interceptors. Resolves spring-projects#208 Signed-off-by: Chris Bono <chris.bono@gmail.com>
This commit adds the ability to filter out services from being bound to server factories. Resolves spring-projects#207 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com> Signed-off-by: Chris Bono <chris.bono@gmail.com>
This commit updates some tests and the contract slightly of the previous commit to allow a serverFactory parameter as part of the inputs to the service filter and tests all variants of server factories via `@ParameterizedTest` See spring-projects#207 Signed-off-by: Chris Bono <chris.bono@gmail.com>
onobc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This is currently based off of main but in reality it based off of #214 and should be rebased once #214 is merged
This combines PR #213 and a refactoring as per 4cd7430