Skip to content

Conversation

@onobc
Copy link
Contributor

@onobc onobc commented Jul 4, 2025

See #207

See spring-projects#207

Signed-off-by: Chris Bono <chris.bono@gmail.com>
@onobc onobc requested a review from dsyer July 4, 2025 21:18
@onobc onobc added the documentation Improvements or additions to documentation label Jul 4, 2025
@dsyer dsyer merged commit 4daec6a into spring-projects:main Jul 4, 2025
5 checks passed
@onobc onobc deleted the GH-207-add-docs-for-service-filtering branch July 4, 2025 21:28
@Meijuh
Copy link
Contributor

Meijuh commented Jul 5, 2025

I can confirm service filtering is working. However, filtering out the "health service" and "reflection service" might be a more valuable example, if you agree not having them on in-process servers is good practice:

return (serviceDefinition, __) ->
        !HealthGrpc.SERVICE_NAME.equals(serviceDefinition.getServiceDescriptor().getName())
            && !ServerReflectionGrpc.SERVICE_NAME.equals(
                serviceDefinition.getServiceDescriptor().getName())

Looking forward to a 0.9.0 release.

@onobc
Copy link
Contributor Author

onobc commented Jul 5, 2025

I can confirm service filtering is working. However, filtering out the "health service" and "reflection service" might be a more valuable example, if you agree not having them on in-process servers is good practice:

return (serviceDefinition, __) ->
        !HealthGrpc.SERVICE_NAME.equals(serviceDefinition.getServiceDescriptor().getName())
            && !ServerReflectionGrpc.SERVICE_NAME.equals(
                serviceDefinition.getServiceDescriptor().getName())

Looking forward to a 0.9.0 release.

Good suggestion @Meijuh . PTAL at the result here

@Meijuh
Copy link
Contributor

Meijuh commented Jul 6, 2025

LGTM!😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants