Fix SecurityContext leakage in AuthenticationProcessInterceptor #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hyunsang Han <gustkd3@gmail.com>
HyunSangHan
force-pushed
the
security-context-cleanup
branch
from
b7d61f3 to
1e356a2
Compare
Contributor
Author
|
@dsyer * @author Dave Syer
+ * @author Hyunsang HanCan I submit this with PR? 😅 |
HyunSangHan
added a commit
to HyunSangHan/spring-grpc
that referenced
this pull request
Aug 16, 2025
Signed-off-by: Hyunsang Han <gustkd3@gmail.com>
dsyer
pushed a commit
that referenced
this pull request
Aug 16, 2025
Signed-off-by: Hyunsang Han <gustkd3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthenticationProcessInterceptorwas setting authentication in theSecurityContextbut not clearing it after a request completed, allowing authentication state to leak between requests on the same thread.This could let anonymous requests inherit the authentication from previous authenticated requests, potentially bypassing security checks.
The fix wraps the call listener so that the
SecurityContextis always cleared when a request completes, is cancelled, or fails with an error.Fixes #245