Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 31 additions & 6 deletions .github/workflows/ci-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,23 +15,48 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up JDK 17 (0.x)
if: github.base_ref == '0.x'
- name: Set up JDK 25
uses: actions/setup-java@v4
with:
java-version: '25'
distribution: 'liberica'
cache: maven
- name: Build, test, and run samples using Java 25 w/ target=17
run: |
./mvnw -B clean install

- name: Set up JDK 17
uses: actions/setup-java@v4
with:
java-version: '17'
distribution: 'temurin'
cache: maven
- name: Set up JDK 25 (main)
if: github.base_ref == 'main'
- name: Run samples built w/ Java 25 w/ target=17 using Java 17
run: |
pushd samples > /dev/null
../mvnw test \
-Dmaven-checkstyle-plugin.config.location=../src/checkstyle
popd > /dev/null

- name: Set up JDK 25
uses: actions/setup-java@v4
with:
java-version: '25'
distribution: 'liberica'
cache: maven
- name: Build and test
- name: Build and run samples using Java 25 w/ target=25
run: |
./mvnw -B clean install
pushd samples > /dev/null
../mvnw clean install \
-pl '!grpc-server-kotlin' \
-Dmaven-checkstyle-plugin.config.location=../src/checkstyle \
-Djava.version=25
../mvnw clean install \
-pl 'grpc-server-kotlin' \
-Dmaven-checkstyle-plugin.config.location=../src/checkstyle \
-Djava.version=24
popd > /dev/null

- name: Capture Test Results
if: failure()
uses: actions/upload-artifact@v4
Expand Down
11 changes: 1 addition & 10 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
name: Deploy Jars
on:
push:
branches: [ main, 0.x ]
branches: [ main ]

jobs:
build:
Expand All @@ -13,16 +13,7 @@ jobs:
if: ${{ github.repository == 'spring-projects/spring-grpc' }}

steps:
- uses: actions/checkout@v4
- name: Set up JDK 17 (0.x)
if: github.ref != 'refs/heads/main'
uses: actions/setup-java@v4
with:
java-version: '17'
distribution: 'temurin'
cache: maven
- name: Set up JDK 25 (main)
if: github.ref == 'refs/heads/main'
uses: actions/setup-java@v4
with:
java-version: '25'
Expand Down
5 changes: 3 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@
<spring-javaformat-checkstyle.version>0.0.43</spring-javaformat-checkstyle.version>
<disable.format.checks>false</disable.format.checks>
<disable.checkstyle.checks>false</disable.checkstyle.checks>
<maven-checkstyle-plugin.config.location>src/checkstyle</maven-checkstyle-plugin.config.location>
<maven-checkstyle-plugin.failsOnError>true</maven-checkstyle-plugin.failsOnError>
<maven-checkstyle-plugin.failOnViolation>true</maven-checkstyle-plugin.failOnViolation>
<maven-checkstyle-plugin.includeTestSourceDirectory>true</maven-checkstyle-plugin.includeTestSourceDirectory>
Expand Down Expand Up @@ -165,9 +166,9 @@
<phase>validate</phase>
<inherited>true</inherited>
<configuration>
<configLocation>src/checkstyle/checkstyle.xml</configLocation>
<configLocation>${maven-checkstyle-plugin.config.location}/checkstyle.xml</configLocation>
<propertyExpansion>
config_loc=src/checkstyle
config_loc=${maven-checkstyle-plugin.config.location}
</propertyExpansion>
<skip>${disable.checkstyle.checks}</skip>
<includeTestSourceDirectory>${maven-checkstyle-plugin.includeTestSourceDirectory}</includeTestSourceDirectory>
Expand Down
2 changes: 1 addition & 1 deletion samples/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@
<name>Parent Demo</name>

<modules>
<module>grpc-server</module>
<module>grpc-client</module>
<module>grpc-oauth2</module>
<module>grpc-reactive</module>
<module>grpc-secure</module>
<module>grpc-server</module>
<module>grpc-server-kotlin</module>
<module>grpc-server-netty-shaded</module>
<module>grpc-tomcat</module>
Expand Down
Loading