This repository was archived by the owner on Mar 30, 2023. It is now read-only.
Support transaction initiation in ob endpoints #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
suggested changes
Feb 13, 2018
| else { | ||
| this.headerMapper = new SimpleKafkaHeaderMapper(); | ||
| } | ||
| // TODO - add isTransactional() to KafkaTemplate |
Contributor
There was a problem hiding this comment.
Let's do this first!
Merge there, then fix here and merge as well!
garyrussell
changed the title
garyrussell
force-pushed
the
txHandler
branch
from
346ec2f to
4ad93cd
Compare
Contributor
Author
|
ping |
garyrussell
added a commit
to garyrussell/spring-cloud-stream-binder-kafka
that referenced
this pull request
Feb 14, 2018
Resolves spring-attic#305 Requires spring-attic/spring-integration-kafka#196 `ProducerConfigurationMessageHandler` overrode `handleMessageInternal` to support producer-initiated transactions. Now that the superclass extends `ARPMH`, this method is no longer overridable. Spring Integration Kafka's `KafkaProducerMessageHandler` now detects a transactional `KafkaTemplate` and will automatically start a transaction if needed, so there is no longer any need to override that method.
garyrussell
added a commit
to garyrussell/spring-cloud-stream-binder-kafka
that referenced
this pull request
Feb 14, 2018
Resolves spring-attic#305 Requires spring-attic/spring-integration-kafka#196 `ProducerConfigurationMessageHandler` overrode `handleMessageInternal` to support producer-initiated transactions. Now that the superclass extends `ARPMH`, this method is no longer overridable. Spring Integration Kafka's `KafkaProducerMessageHandler` now detects a transactional `KafkaTemplate` and will automatically start a transaction if needed, so there is no longer any need to override that method.
garyrussell
added a commit
to garyrussell/spring-cloud-stream-binder-kafka
that referenced
this pull request
Feb 14, 2018
Resolves spring-attic#305 Requires spring-attic/spring-integration-kafka#196 `ProducerConfigurationMessageHandler` overrode `handleMessageInternal` to support producer-initiated transactions. Now that the superclass extends `ARPMH`, this method is no longer overridable. Spring Integration Kafka's `KafkaProducerMessageHandler` now detects a transactional `KafkaTemplate` and will automatically start a transaction if needed, so there is no longer any need to override that method. No additional tests needed; see `KafkaTransactionTests`.
Contributor
|
Any ideas what's going on with the test-case: ? See Travis report. Thanks |
Contributor
Author
|
No, but it's unrelated to this PR; let's get this reviewed, merged and I'll look at that test separately. |
artembilan
pushed a commit
to spring-attic/spring-cloud-stream-binder-kafka
that referenced
this pull request
Feb 14, 2018
Resolves #305 Resolves #308 Requires spring-attic/spring-integration-kafka#196 `ProducerConfigurationMessageHandler` overrode `handleMessageInternal` to support producer-initiated transactions. Now that the superclass extends `ARPMH`, this method is no longer overridable. Spring Integration Kafka's `KafkaProducerMessageHandler` now detects a transactional `KafkaTemplate` and will automatically start a transaction if needed, so there is no longer any need to override that method. No additional tests needed; see `KafkaTransactionTests`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.