Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo Gardle -> Gradle #130

Closed

Conversation

Projects
None yet
2 participants
@cirosantilli
Copy link
Contributor

commented Mar 27, 2015

No description provided.

@artembilan

This comment has been minimized.

Copy link
Member

commented Mar 27, 2015

Thank you for finding that and for the fix anyway.
But we can't accept the patch without the CLA signing confirmation: https://github.com/spring-projects/spring-integration-samples/wiki

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2015

I've tried to sign it, let me know if it didn't work.

Even PRs have boilerplate in the Java world :)

@artembilan

This comment has been minimized.

Copy link
Member

commented Mar 29, 2015

I've tried to sign it, let me know if it didn't work.

You had to receive a confirmation email with CLA Number.

From other side it's not an issue and we can fix it for you, but there won't be your commit in the project.

Even PRs have boilerplate in the Java world

Nothing specific: just some rules of Open Source

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2015

I've received the email. Do I need to do something else?

@artembilan

This comment has been minimized.

Copy link
Member

commented Mar 30, 2015

No, that's fine.
Thank you for the contribution.
Merging you PR...

For the future, please, follow with those Contribution rules: "JIRA first!" is good way to start.

@artembilan

This comment has been minimized.

Copy link
Member

commented Mar 30, 2015

Merged as :b32cd1e
with additional fix to the same typo in other places 😄

@artembilan artembilan closed this Mar 30, 2015

@cirosantilli cirosantilli deleted the cirosantilli:typo-gradle branch Mar 30, 2015

@cirosantilli

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2015

I take back what I've said about Java: GNU requires you to send them a physical letter :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.