Skip to content

Update DLT log message and docs #3656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Update DLT log message and docs #3656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ng-kafka-docs/src/main/antora/modules/ROOT/pages/retrytopic/dlt-strategies.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public void processMessage(MyPojo message) {
}

@DltHandler
public void processMessage(MyPojo message) {
public void processDltMessage(MyPojo message) {
// ... message processing, persistence, etc
}
----
Expand Down
1 change: 0 additions & 1 deletion spring-kafka-docs/src/main/antora/modules/ROOT/pages/retrytopic/features.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@ public RetryTopicConfiguration myRetryTopic(KafkaTemplate<String, MyPojo> templa
return RetryTopicConfigurationBuilder
.newInstance()
.dltRoutingRules(Map.of("-deserialization", Set.of(DeserializationException.class)))
.create(kafkaOperations)
.create(template);
}
----
Expand Down
3 changes: 2 additions & 1 deletion ...kafka/src/main/java/org/springframework/kafka/listener/DeadLetterPublishingRecoverer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
* @author Gary Russell
* @author Tomaz Fernandes
* @author Watlas R
* @author Borahm Lee
* @since 2.2
*
*/
Expand Down Expand Up @@ -571,7 +572,7 @@ private void sendOrThrow(ProducerRecord<Object, Object> outRecord,

private void maybeThrow(ConsumerRecord<?, ?> record, Exception exception) {
String message = String.format("No destination returned for record %s and exception %s. " +
"failIfNoDestinationReturned: %s", KafkaUtils.format(record), exception,
"throwIfNoDestinationReturned: %s", KafkaUtils.format(record), exception,
this.throwIfNoDestinationReturned);
this.logger.warn(message);
if (this.throwIfNoDestinationReturned) {
Expand Down