Skip to content

Update listener observation operation tag #4094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

Update listener observation operation tag #4094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../src/main/java/org/springframework/kafka/support/micrometer/KafkaListenerObservation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ public KeyValues getLowCardinalityKeyValues(KafkaRecordReceiverContext context)
KeyValues keyValues = KeyValues.of(
ListenerLowCardinalityTags.LISTENER_ID.withValue(context.getListenerId()),
ListenerLowCardinalityTags.MESSAGING_SYSTEM.withValue("kafka"),
ListenerLowCardinalityTags.MESSAGING_OPERATION.withValue("receive"),
ListenerLowCardinalityTags.MESSAGING_OPERATION.withValue("process"),
ListenerLowCardinalityTags.MESSAGING_SOURCE_NAME.withValue(context.getSource()),
ListenerLowCardinalityTags.MESSAGING_SOURCE_KIND.withValue("topic")
);
Expand Down Expand Up @@ -269,7 +269,7 @@ public KeyValues getHighCardinalityKeyValues(KafkaRecordReceiverContext context)

@Override
public String getContextualName(KafkaRecordReceiverContext context) {
return context.getSource() + " receive";
return context.getSource() + " process";
}

private static @Nullable String getConsumerId(@Nullable String groupId, @Nullable String clientId) {
Expand Down
7 changes: 4 additions & 3 deletions ...ng-kafka/src/test/java/org/springframework/kafka/support/micrometer/ObservationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@
* @author Christian Mergenthaler
* @author Soby Chacko
* @author Francois Rosiere
* @author Christian Fredriksson
*
* @since 3.0
*/
Expand Down Expand Up @@ -377,14 +378,14 @@ private SimpleSpan assertThatListenerSpanTags(Deque<SimpleSpan> spans, int tagSi
Map.entry("messaging.kafka.consumer.group", consumerGroup),
Map.entry("messaging.kafka.message.offset", offset),
Map.entry("messaging.kafka.source.partition", partition),
Map.entry("messaging.operation", "receive"),
Map.entry("messaging.operation", "process"),
Map.entry("messaging.source.kind", "topic"),
Map.entry("messaging.source.name", sourceName),
Map.entry("messaging.system", "kafka")));
if (keyValues.length > 0) {
Arrays.stream(keyValues).forEach(entry -> assertThat(span.getTags()).contains(entry));
}
assertThat(span.getName()).isEqualTo(sourceName + " receive");
assertThat(span.getName()).isEqualTo(sourceName + " process");
return span;
}

Expand All @@ -406,7 +407,7 @@ private void assertThatListenerHasTimerWithNameAndTags(MeterRegistryAssert meter
meterRegistryAssert.hasTimerWithNameAndTags("spring.kafka.listener",
KeyValues.of(
"messaging.kafka.consumer.group", consumerGroup,
"messaging.operation", "receive",
"messaging.operation", "process",
"messaging.source.kind", "topic",
"messaging.source.name", destName,
"messaging.system", "kafka",
Expand Down