GH-1184 - Introduce JSpecify #1201
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Olaszewski <piotr.olaszewski@thulium.pl>
Signed-off-by: Piotr Olaszewski <piotr.olaszewski@thulium.pl>
Signed-off-by: Piotr Olaszewski <piotr.olaszewski@thulium.pl>
Signed-off-by: Piotr Olaszewski <piotr.olaszewski@thulium.pl>
Contributor
|
Fantastic! This is a substantial amount of work so thank you very much for doing that 🙏 I will merge this PR even if it is a draft, and I will take care of the remaining modules ( |
fmbenhassine
added a commit
that referenced
this pull request
Oct 31, 2025
- Remove separate profile for jSpecify checks - Update errorprone and nullaway versions - Add jSpecify checks in test and test-autoconfigure modules - Exclude o.s.shell.test.jediterm from jSpecify checks (as it's a shaded fork) - Remove usage of org.springframework.lang.Nullable Resolves #1184
Contributor
|
Rebased, squashed and merged as 63eb82e. Revised in 8506e9b with just some minor updates (no need for an extra profile for nullability checks, no need for the With that, I think we have a good start supporting jSpecify annotations for Thanks again for this amazing contribution! Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
nullawaymaven profilenullawayprofile inci-pr.ymlworkflowCloses #1184