Simplify error handling. NFC.

espindola · espindola · commit 5329c75e4f2a · 2017-09-21T22:50:52.000Z
llvm-svn: 313930
diff --git a/lld/COFF/LTO.cpp b/lld/COFF/LTO.cpp
@@ -49,10 +49,8 @@ static void diagnosticHandler(const DiagnosticInfo &DI) {
 }
 
 static void checkError(Error E) {
-  handleAllErrors(std::move(E), [&](ErrorInfoBase &EIB) -> Error {
-    error(EIB.message());
-    return Error::success();
-  });
+  handleAllErrors(std::move(E),
+                  [&](ErrorInfoBase &EIB) { error(EIB.message()); });
 }
 
 static void saveBuffer(StringRef Buffer, const Twine &Path) {
diff --git a/lld/ELF/LTO.cpp b/lld/ELF/LTO.cpp
@@ -61,10 +61,8 @@ static void diagnosticHandler(const DiagnosticInfo &DI) {
 }
 
 static void checkError(Error E) {
-  handleAllErrors(std::move(E), [&](ErrorInfoBase &EIB) -> Error {
-    error(EIB.message());
-    return Error::success();
-  });
+  handleAllErrors(std::move(E),
+                  [&](ErrorInfoBase &EIB) { error(EIB.message()); });
 }
 
 static std::unique_ptr<lto::LTO> createLTO() {

Original file line number	Diff line number	Diff line change
`@@ -49,10 +49,8 @@ static void diagnosticHandler(const DiagnosticInfo &DI) {`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`static void checkError(Error E) {`
`52`		`- handleAllErrors(std::move(E), [&](ErrorInfoBase &EIB) -> Error {`
`53`		`- error(EIB.message());`
`54`		`- return Error::success();`
`55`		`- });`
	`52`	`+ handleAllErrors(std::move(E),`
	`53`	`+ [&](ErrorInfoBase &EIB) { error(EIB.message()); });`
`56`	`54`	`}`
`57`	`55`
`58`	`56`	`static void saveBuffer(StringRef Buffer, const Twine &Path) {`
Original file line number	Diff line number	Diff line change
`@@ -61,10 +61,8 @@ static void diagnosticHandler(const DiagnosticInfo &DI) {`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`static void checkError(Error E) {`
`64`		`- handleAllErrors(std::move(E), [&](ErrorInfoBase &EIB) -> Error {`
`65`		`- error(EIB.message());`
`66`		`- return Error::success();`
`67`		`- });`
	`64`	`+ handleAllErrors(std::move(E),`
	`65`	`+ [&](ErrorInfoBase &EIB) { error(EIB.message()); });`
`68`	`66`	`}`
`69`	`67`
`70`	`68`	`static std::unique_ptr<lto::LTO> createLTO() {`