-
-
Notifications
You must be signed in to change notification settings - Fork 40
Add JSON formatting #42 #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey team, @bnasslahsen @gklp @DennisHalmstad |
|
vote for this one |
|
@gklp @bnasslahsen @adrien-ben Any chance to check it out? :) |
DennisHalmstad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this
|
@DennisHalmstad cool! Thanks for the comment and approve! |
|
Hi, looks good to me but I'm not a member of the team, sorry :/ |
|
There is no need for extra dependency. |
|
@bnasslahsen thank you for reaching out! I've tested it locally and the pretty printer doesn't work. Frankly, I can't even find it in the code using the flag. Could you perhaps provide an example of the command? |
|
see the https://springdoc.org/#properties and the code reference https://github.com/springdoc/springdoc-openapi/blob/3745c32cdd742cf3e7e1ddb3f393eef238d69ba0/springdoc-openapi-common/src/main/java/org/springdoc/core/SpringDocConfigProperties.java#L132 The sample command was in the referenced issue #12 (comment) mvn verify -Dspringdoc.writer-with-default-pretty-printer=trueAnd you are still unable to make it work, as described in the contribution guidelines Make sure you provide a Minimal, Reproducible Example - with HelloController that reproduces the problem. |
|
Thanks for the references, I'll see to follow through in more depth and if needed to provide you with a minimal reproducible example. :) |
I took the liberty of adding the PR for the issue.
It adds a lightweight dependency of
org.json. Used to parse the string in case we want to write to a.jsonfile and then indent it properly.Please do share your thoughts.
Related to: #42