Skip to content
This repository was archived by the owner on Apr 10, 2024. It is now read-only.

Conversation

@mpetrun5
Copy link
Contributor

Avoid multiplying big floats to avoid floating point rounding error.

Description

Related Issue Or Context

Closes: #31

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@mpetrun5 mpetrun5 changed the title Fix large floating point wei conversion fix: fix large floating point wei conversion Feb 14, 2023
@mpetrun5 mpetrun5 changed the title fix: fix large floating point wei conversion fix: large floating point wei conversion Feb 14, 2023
@mpetrun5 mpetrun5 merged commit 741da0e into main Feb 14, 2023
@mpetrun5 mpetrun5 deleted the mpetrun5/fix-decimal-conversion branch February 14, 2023 10:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix large floating point calculation error

3 participants