Skip to content

not checking sqlflow custom models parameters #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 27, 2019
Merged

not checking sqlflow custom models parameters #1556

merged 2 commits into from
Dec 27, 2019

Conversation

@typhoonzero
Copy link
Collaborator

@typhoonzero typhoonzero commented Dec 27, 2019

Fix #1555

@shendiaomo shendiaomo mentioned this pull request Dec 27, 2019
Closed
@shendiaomo
Copy link
Collaborator

shendiaomo commented Dec 27, 2019 •
edited
Loading

Great! I've added an issue #1558 to revise relative functionalities.

@shendiaomo shendiaomo self-requested a review December 27, 2019 09:42
shendiaomo
shendiaomo previously approved these changes Dec 27, 2019
View reviewed changes
@wangkuiyi wangkuiyi merged commit 9407c4b into sql-machine-learning:develop Dec 27, 2019
@typhoonzero typhoonzero deleted the fix_check_sqlflow_models_parameter branch July 17, 2020 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shendiaomo shendiaomo shendiaomo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New sqlflow models may not pass attribute validation

3 participants

@typhoonzero @shendiaomo @wangkuiyi