Add doc string for models in sqlflow_models #1717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
reviewed
Jan 15, 2020
|
|
||
| // ExtractDocString extracts parameter documents from python doc strings | ||
| func ExtractDocString(module ...string) { | ||
| cmd := exec.Command("python", "-uc", fmt.Sprintf("__import__('extract_docstring').print_param_doc('%s')", strings.Join(module, "', '"))) |
Collaborator
There was a problem hiding this comment.
Should we make a local call here to print the docstring, other than start a process?
Collaborator
Author
There was a problem hiding this comment.
That's somewhat hard to implement because we have to import the classes to get the docstrings. I have investigated several python bindings of golang but they are either too primitive (go-python) or not as reliable.
wangkuiyi
approved these changes
Jan 15, 2020
typhoonzero
reviewed
Jan 16, 2020
| if e != nil { | ||
| log.Println("ExtractDocString failed: ", e, string(output)) | ||
| } | ||
| if e := json.Unmarshal(output, &PremadeModelParamsDocs); e != nil { |
Collaborator
There was a problem hiding this comment.
Maybe add a comment that unmarshal can append entries rather than overwrite it: https://golang.org/pkg/encoding/json/#Unmarshal
| export PYTHONPATH=$GOPATH/src/sqlflow.org/sqlflow/python | ||
|
|
||
| sqlflowserver & | ||
| sleep 10 |
Collaborator
There was a problem hiding this comment.
Is it possible to change this sleep to a while loop that pings the SQLFlow server?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fix #1558
A pitfall is that it takes longer for repl/sqlflowserver to start-up because we have to
import tensorflow